Skip to content

feat(contexts): nest menu items one level deep - #3137

Closed
rubenvdlinde wants to merge 2 commits into
feat/noid/app-menu-savingfrom
feat/noid/app-menu-nesting
Closed

feat(contexts): nest menu items one level deep#3137
rubenvdlinde wants to merge 2 commits into
feat/noid/app-menu-savingfrom
feat/noid/app-menu-nesting

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Part of #3099, on top of #3136 (menu saving). A menu item can sit under another item, one level deep, for example a few views under the table they belong to. This replaces #3088 by @remko48.

Size: 248 lines: 100 code, 128 tests and 20 generated OpenAPI.

What changes

  • When saving a menu, an item can name its parent by its position in the list (parentIndex). Nesting goes one level deep: a parent can't have a parent of its own.
  • The response gives each item its parentId.

How it was tested

On Nextcloud 34 with PostgreSQL:

🖼️ Screenshots

Backend only, no UI changes.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

This was referenced Oct 22, 2026
Open
Open
@rubenvdlinde
rubenvdlinde added this pull request to stack #3139 October 22, 2026 11:42
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-saving branch from 6540b64 to b167dd6 Compare October 22, 2026 13:25
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch from 090ac9c to 14a341b Compare October 22, 2026 13:25
@rubenvdlinde rubenvdlinde mentioned this pull request Oct 22, 2026
Open
3 of 5 tasks
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch from 14a341b to 28a56c3 Compare October 23, 2026 08:05
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-saving branch from b167dd6 to 85b998e Compare October 23, 2026 08:05
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch from 28a56c3 to a994451 Compare October 24, 2026 08:09
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-saving branch 2 times, most recently from 9247115 to b99771d Compare October 26, 2026 08:51
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch 2 times, most recently from 70eda55 to 065c9b9 Compare October 26, 2026 09:24
@rubenvdlinde
rubenvdlinde marked this pull request as ready for review October 26, 2026 09:25
@jospoortvliet jospoortvliet mentioned this pull request Oct 26, 2026
Open
enjeck
enjeck reviewed Oct 31, 2026
View reviewed changes

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3099 doesn't cover menu items inside other items. So not sure the expectation here

@enjeck

enjeck commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

#3099 doesn't cover menu items inside other items. So not sure the expectation here

Oh, my bad. Now I see it in one of your images. I would have to think about it then, i didn't notice earlier

@rubenvdlinde rubenvdlinde mentioned this pull request Nov 2, 2026
Open
@rubenvdlinde
rubenvdlinde marked this pull request as draft November 2, 2026 11:14
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch from 065c9b9 to de11d95 Compare November 2, 2026 11:17
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-saving branch 2 times, most recently from 3593dbc to 9c7797a Compare November 2, 2026 11:23
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch from de11d95 to 06745a2 Compare November 2, 2026 11:23
rubenvdlinde and others added 2 commits November 3, 2026 15:51
@rubenvdlinde @remko48
feat(menu): nest menu items one level deep
bfd96c5 
Co-authored-by: remko48 <remko@conduction.nl>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
@rubenvdlinde
chore(api): regenerate the OpenAPI spec and TypeScript types
64c061c 
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-saving branch from 9c7797a to eb6d3f4 Compare November 3, 2026 14:51
@rubenvdlinde
rubenvdlinde force-pushed the feat/noid/app-menu-nesting branch from 06745a2 to 64c061c Compare November 3, 2026 14:51
@rubenvdlinde
rubenvdlinde removed this pull request from stack #3139 November 4, 2026 10:41
@rubenvdlinde

rubenvdlinde commented Nov 4, 2026

Copy link
Copy Markdown
Author

Replaced by the rebuilt #3135 and #3138, which follow the proposal on #3100.

@rubenvdlinde
rubenvdlinde deleted the feat/noid/app-menu-nesting branch November 4, 2026 12:36
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjeck enjeck enjeck left review comments
@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

AI assisted feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubenvdlinde @enjeck @nextcloud-command